Fix for issue 295

[tmeckel]

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

• Fixes xADComputer: Remove unnecessary cast #295

Task list

• Added an entry under the Unreleased section in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[codecov-io]

Codecov Report

Merging #313 into dev will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #313   +/-   ##
===================================
  Coverage    91%    91%           
===================================
  Files        19     19           
  Lines      2310   2310           
  Branches     10     10           
===================================
  Hits       2115   2115           
  Misses      185    185           
  Partials     10     10

[johlju]

Thanks for sending this PR in!

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @tmeckel)

---

appveyor.yml, line 43 at r2 (raw file):

        Invoke-AppveyorAfterTestTask `
            -Type 'Wiki' `
            -ResourceModuleName $moduleName

This was just added in another PR. If you rebase this will be added. So this can be removed from this PR. 🙂

---

CHANGELOG.md, line 39 at r2 (raw file):

Fixed description of RestoreFromRecycleBin ([Issue #292](https://github.com/PowerShell/xActiveDirectory/issues/292))

This reference an already closed issue, and not seeing a change in this PR that this reference to? 🤔

---

CHANGELOG.md, line 69 at r2 (raw file):

- Changes to appveyor.yml
  - Enabled auto documentation ([issue #289](https://github.com/PowerShell/xActiveDirectory/issues/289)).

This was already resolved in another PR.

[tmeckel]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @johlju)

---

appveyor.yml, line 43 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

        Invoke-AppveyorAfterTestTask `
            -Type 'Wiki' `
            -ResourceModuleName $moduleName

This was just added in another PR. If you rebase this will be added. So this can be removed from this PR. 🙂

TODO: Okay .. will do

---

CHANGELOG.md, line 39 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Fixed description of RestoreFromRecycleBin ([Issue #292](https://github.com/PowerShell/xActiveDirectory/issues/292))

This reference an already closed issue, and not seeing a change in this PR that this reference to? 🤔

TODO: Will remove this

---

CHANGELOG.md, line 69 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

- Changes to appveyor.yml
  - Enabled auto documentation ([issue #289](https://github.com/PowerShell/xActiveDirectory/issues/289)).

This was already resolved in another PR.

TODO: Okay ... will remove this

[tmeckel]

Basically the only thing that will stay in that PR will be issue #295 ... Right?

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @johlju)

[johlju]

Yes, it looks like that! The other issues was already resolved. 🙂

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @johlju)

[tmeckel]

I removed all the obsolete changes from the PR. Should again be ready for review.

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @johlju)

[johlju]

Great work @tmeckel!

Reviewed 3 of 3 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved