Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADUser: Should always return all properties from Get-TargetResource #488

Closed
johlju opened this issue Aug 18, 2019 · 1 comment · Fixed by #569
Closed

ADUser: Should always return all properties from Get-TargetResource #488

johlju opened this issue Aug 18, 2019 · 1 comment · Fixed by #569
Assignees
@X-Guardian
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Aug 18, 2019

If a AD user is not found the Get-TargetResource function should return all properties, but those properties that cannot be retrieved should be set to $null. Properties that cannot be retrieved regardless if the user exist or not should be set to the same value as passed in the parameter.
@johlju johlju added bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Aug 18, 2019
@johlju johlju changed the title ADUser: Should always return all properties fromGet-TargetResource ADUser: Should always return all properties from Get-TargetResource Aug 18, 2019
@johlju
Copy link
Member Author

johlju commented Aug 19, 2019

This issue should also resolve that the unit test evaluates so that the properties are returned correctly. Also add these properties to the integration test.

@johlju johlju mentioned this issue Aug 19, 2019
Merged
10 tasks
@X-Guardian X-Guardian mentioned this issue Feb 11, 2020
Merged
9 tasks
@X-Guardian X-Guardian added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Feb 11, 2020
@X-Guardian X-Guardian self-assigned this Feb 11, 2020
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@X-Guardian X-Guardian

Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ADUser: Refactor Module and Unit Tests X-Guardian/ActiveDirectoryDsc
2 participants
@johlju @X-Guardian