Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ManifestVersion to $schema and validate #199

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

SteveL-MSFT
Copy link
Member

PR Summary

Change manifestVersion in the resource manifest to $schema using a URI instead of a semver. Added code to validate URI is a supported version by abstracting new import_manifest function.

PR Context

Fix #127

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Sep 20, 2023

@michaeltlombardi I'm leaving it to you to update the schemas as a follow-up PR

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Sep 21, 2023
Merged via the queue into PowerShell:main with commit c2fa7da Sep 21, 2023
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the manifest-version branch September 21, 2023 22:58
michaeltlombardi added a commit to michaeltlombardi/DSC that referenced this pull request Sep 27, 2023
This change updates the schema definitions to replace the `manifestVersion`
property for resource manifests with the more canonical `$schema` keyword
to reflect the changes from PowerShell#199.
michaeltlombardi added a commit to michaeltlombardi/DSC that referenced this pull request Sep 27, 2023
This change updates the schema definitions to replace the `manifestVersion`
property for resource manifests with the more canonical `$schema` keyword
to reflect the changes from PowerShell#199.
michaeltlombardi added a commit to michaeltlombardi/DSC that referenced this pull request Sep 27, 2023
This change updates the schema definitions to replace the `manifestVersion`
property for resource manifests with the more canonical `$schema` keyword
to reflect the changes from PowerShell#199.
michaeltlombardi added a commit to michaeltlombardi/DSC that referenced this pull request Sep 27, 2023
This change updates the reference documentation and the changelog
to reflect the changes that were included in the `alpha.3` release:

- PowerShell#197
- PowerShell#198
- PowerShell#199
michaeltlombardi added a commit to michaeltlombardi/DSC that referenced this pull request Sep 29, 2023
This change updates the reference documentation and the changelog
to reflect the changes that were included in the `alpha.3` release:

- PowerShell#197
- PowerShell#198
- PowerShell#199
michaeltlombardi added a commit to michaeltlombardi/DSC that referenced this pull request Sep 29, 2023
This change updates the schema definitions to replace the `manifestVersion`
property for resource manifests with the more canonical `$schema` keyword
to reflect the changes from PowerShell#199.
michaeltlombardi added a commit to michaeltlombardi/DSC that referenced this pull request Sep 29, 2023
This change updates the reference documentation and the changelog
to reflect the changes that were included in the `alpha.3` release:

- PowerShell#197
- PowerShell#198
- PowerShell#199
michaeltlombardi added a commit to michaeltlombardi/DSC that referenced this pull request Sep 30, 2023
This change updates the reference documentation and the changelog
to reflect the changes that were included in the `alpha.3` release:

- PowerShell#197
- PowerShell#198
- PowerShell#199
michaeltlombardi added a commit to michaeltlombardi/DSC that referenced this pull request Sep 30, 2023
This change updates the reference documentation and the changelog
to reflect the changes that were included in the `alpha.3` release:

- PowerShell#197
- PowerShell#198
- PowerShell#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update or replace manifestVersion
2 participants