Update tree-sitter grammar and tests addressing Dongbo's feedback #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
approved these changes
Oct 9, 2023
SteveL-MSFT
force-pushed
the
tree-sitter-update
branch
from
102a0a5
to
2b4e919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
nodebindings as they aren't usedpalproject from rust-analyzer as it causes it to crash on macOS[functionOne(functionTwo().member)]which produces anexpressionnode, so tests updated to account for thisHave not figured out yet how to have
[Test] stringjust pass-through as a string literal. cc @daxian-dbwPR Context