Add initial library for file resource
#225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## PR Summary - Add code to compute checksums for SHA-1, SHA-256 and SHA-512 hash algorithms. - Add code to generalize checking the environment and prompting the user to attach a debugger. ## PR Context The `file_lib` contains the implementation for the `file` resource.
SteveL-MSFT
reviewed
Oct 11, 2023
SteveL-MSFT
reviewed
Oct 11, 2023
SteveL-MSFT
requested changes
Oct 11, 2023
SteveL-MSFT
reviewed
Oct 11, 2023
file_lib/src/debug.rs
Outdated
Comment on lines
21
to
43
| pub fn check_debug(command: &String) { | ||
| if env::var("DEBUG_DSC").is_ok() { | ||
| let debug_args: Vec<String> = env::var(DEBUG_ENV_VAR) | ||
| .unwrap() | ||
| .split(',') | ||
| .map(|s| s.to_lowercase()) | ||
| .collect(); | ||
|
|
||
| if debug_args.contains(command) { | ||
| eprintln!( | ||
| "attach debugger to pid {} and press any key to continue", | ||
| std::process::id() | ||
| ); | ||
| loop { | ||
| let event = event::read().unwrap(); | ||
| if let event::Event::Key(_key) = event { | ||
| break; | ||
| } | ||
| eprintln!("Unexpected event: {event:?}"); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We should probably pull this into it's own crate to be used by different projects within this repo, but that can be done as a separate PR
There was a problem hiding this comment.
Yeah, I wasn't sure where to put it. I didn't know if it belonged in dsc_lib or a standalone create, or something new like dsc_utils, and figured we could move it later. I have a similar refactor a function for the common code for reading STDIN.
There was a problem hiding this comment.
@miroman9364 can you open an issue so we refactor that common code, probably a dsc_utils crate makes sense.
Refactor duplicate code to take advantage of common `Digest` Co-authored-by: Steve Lee <slee@microsoft.com>
- added the `file_lib` project - list of projects was getting long, so refactored onto multiple lines (sorted project names)
|
Build file is updated, build and test clean. |
SteveL-MSFT
approved these changes
Oct 12, 2023
- Clippy was unhappy with names, potential panics, and moves. - There is a key release for the enter key already buffered when the application starts; ignore this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
The
file_libcontains the implementation for thefileresource.PR Summary
PR Context