Implement use of tree-sitter parser #241

SteveL-MSFT · 2023-10-20T00:54:02Z

PR Summary

The primary change is to use the generated tree-sitter parser.
Grammar was updated to have parent node for arguments and member_access
Grammar updated so that string arguments don't include the quotes
The statement parser creates expression which can contain functions
Added base64 and concat functions for testing
Some clippy fixes as the rules appeared to have been updated

Note that this parser is not integrated yet with config. That will come next replacing resourceId() with real function.

tree-sitter-dscexpression/grammar.js

dsc/src/resource_command.rs

dsc/src/subcommand.rs

dsc_lib/src/parser/functions.rs

dsc_lib/src/parser/mod.rs

registry/src/main.rs

tree-sitter-dscexpression/grammar.js

dsc_lib/src/parser/functions.rs

dsc_lib/src/parser/expressions.rs

dsc_lib/src/parser/functions.rs

dsc_lib/src/parser/expressions.rs

SteveL-MSFT requested review from anmenaga and daxian-dbw October 20, 2023 00:54

SteveL-MSFT force-pushed the tree-sitter-parse branch from 7cf46b4 to d16b48b Compare October 20, 2023 00:55

SteveL-MSFT added the Doc-Impact label Oct 20, 2023

SteveL-MSFT requested review from miroman9364 and tgauth October 20, 2023 04:30

daxian-dbw reviewed Oct 20, 2023

View reviewed changes

SteveL-MSFT commented Oct 24, 2023

View reviewed changes

tree-sitter-dscexpression/grammar.js Outdated Show resolved Hide resolved

SteveL-MSFT commented Oct 24, 2023

View reviewed changes

dsc_lib/src/parser/functions.rs Outdated Show resolved Hide resolved

SteveL-MSFT added 11 commits October 25, 2023 16:19

initial draft

f805d67

use parser

05a8c28

update grammar to have args and memberaccess nodes

b26cdf8

add error handling and unittests

5a7343a

fix clippy

541442b

change order of projects for dependencies first

0a9eede

fix windows build break

2255170

cleanup ordering

8a51628

address Dongbo's feedback

0abdb55

change to use statement as byte array where possible

7521e10

address Dongbo's feedback keeping the structs separate

35175d2

SteveL-MSFT force-pushed the tree-sitter-parse branch from 875a6f3 to 35175d2 Compare October 26, 2023 00:13

daxian-dbw requested changes Oct 26, 2023

View reviewed changes

dsc_lib/src/parser/expressions.rs Outdated Show resolved Hide resolved

dsc_lib/src/parser/functions.rs Outdated Show resolved Hide resolved

dsc_lib/src/parser/functions.rs Outdated Show resolved Hide resolved

remove unused passing around of the dispatcher

13d4e70

daxian-dbw reviewed Oct 26, 2023

View reviewed changes

dsc_lib/src/parser/expressions.rs Outdated Show resolved Hide resolved

rename variable

09a818c

daxian-dbw approved these changes Oct 26, 2023

View reviewed changes

SteveL-MSFT added this pull request to the merge queue Oct 26, 2023

Merged via the queue into PowerShell:main with commit d6acc1d Oct 26, 2023
4 checks passed

SteveL-MSFT deleted the tree-sitter-parse branch October 26, 2023 13:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement use of tree-sitter parser #241

Implement use of tree-sitter parser #241

SteveL-MSFT commented Oct 20, 2023 •

edited

Implement use of tree-sitter parser #241

Implement use of tree-sitter parser #241

Conversation

SteveL-MSFT commented Oct 20, 2023 • edited

PR Summary

SteveL-MSFT commented Oct 20, 2023 •

edited