Rewrite registry resource to support delete operation #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 3, 2024 08:20
anmenaga
approved these changes
Apr 3, 2024
| @@ -117,7 +117,7 @@ if (!$SkipBuild) { | |||
| New-Item -ItemType Directory $target > $null | |||
|
|
|||
| # make sure dependencies are built first so clippy runs correctly | |||
| $windows_projects = @("pal", "ntreg", "ntstatuserror", "ntuserinfo", "registry", "reboot_pending", "wmi-adapter") | |||
There was a problem hiding this comment.
Why "ntstatuserror" and "ntuserinfo" are removed?
There was a problem hiding this comment.
Those libs were used by the old registry resource for handling NT API errors (translating to human readable errors) and for getting the current user for HKCU (it's not a real hive). None of these are needed as the new crate uses win32 apis that abstract all of this.
|
#283 was probably due to the old resource using libraries that called the NT APIs using lots of unsafe code that wasn't written correctly. |
11 tasks
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 12, 2024
This change adds the `delete` method-defining property to the resource manifest schema and updates the `capabilities` enumeration to include `SetHandlesExist` and `Delete`, as implemented in PowerShell#379. It updates both the source and composed schemas.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 15, 2024
This change adds the `delete` method-defining property to the resource manifest schema and updates the `capabilities` enumeration to include `SetHandlesExist` and `Delete`, as implemented in PowerShell#379. It updates both the source and composed schemas.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 16, 2024
This change adds the `delete` method-defining property to the resource manifest schema and updates the `capabilities` enumeration to include `SetHandlesExist` and `Delete`, as implemented in PowerShell#379. It updates both the source and composed schemas.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 18, 2024
This change adds the `delete` method-defining property to the resource manifest schema and updates the `capabilities` enumeration to include `SetHandlesExist` and `Delete`, as implemented in PowerShell#379. It updates both the source and composed schemas.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 18, 2024
This change adds the `delete` method-defining property to the resource manifest schema and updates the `capabilities` enumeration to include `SetHandlesExist` and `Delete`, as implemented in PowerShell#379. It updates both the source and composed schemas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
registryresource to archive folder and excluded from build (no need to review, files moved without changes)registryresource using Registry crate simplifying the code, important behaviors to doc for resources:getto a resource that doesn't exist, don't error. Instead return keys and_exist = falsedeleteto a resource that already doesn't exist, don't error. Instead return keys and_exist = falsedeleteas validdsc resourceoperationsetmethodhandlesExistindicating that the resource will handle_existdirectly sodscwill pass it as-is to the resource with test resource to validate. The engine work to change_existtodeletewill come later after this is merged.dsc resource listto showSetHandlesExistandDeletecapabilitiesregistryresource as it takes JSON via argument instead of stdinPR Context
Fix #283
Partially address #290