Update engine to call delete for resources that don't support _exist directly
#382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
force-pushed
the
delete-exist
branch
from
eeecf88
to
78e9f2e
Compare
11 tasks
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 15, 2024
This change updates guidance for resources that implement the `delete` method to always define the `_exist` property in the JSON schema for the resource's properties, now that DSC can automatically determine whether to delete an instance as implemented in PowerShell#382. This change updates both the source and composed schemas.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 16, 2024
This change updates guidance for resources that implement the `delete` method to always define the `_exist` property in the JSON schema for the resource's properties, now that DSC can automatically determine whether to delete an instance as implemented in PowerShell#382. This change updates both the source and composed schemas.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 18, 2024
This change updates guidance for resources that implement the `delete` method to always define the `_exist` property in the JSON schema for the resource's properties, now that DSC can automatically determine whether to delete an instance as implemented in PowerShell#382. This change updates both the source and composed schemas.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 18, 2024
This change updates guidance for resources that implement the `delete` method to always define the `_exist` property in the JSON schema for the resource's properties, now that DSC can automatically determine whether to delete an instance as implemented in PowerShell#382. This change updates both the source and composed schemas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
deleteon a resource (if it supports it) if_exist = falseis one of the properties and the resource doesn't have theSetHandlesExistcapability.SetHandlesExistcapability, then it will get the raw propertiesTest/Existresource to better validate case that_existis passed throughTest/Deleteresource to validatedeletegets calleddeletepath as all resources would need to supportdelete(you'll get an error message if the resource returns a group response).deleteis a syntheticsetwith_exist, had to write code to convert thegetresponse into asetresponsetestduring configurationsetoperation if the resource doesn't directly implement itPR Context
Fix #290