add metadata to configuration result output #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
added
Doc-Impact
Schema-Impact
11 tasks
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 16, 2024
This changes defines the metadata properties that DSC returns in the results for the `dsc config *` commands, as implemented in PowerShell#405. It defines each metadata property as a separate file in a new folder for metadata schemas for easier reuse, as well as two definitions of the `metadata` property used across different result objects, one for the top-level of a configuration and one for resource instances in that result. This change also required a minor fix to the build script to account for array items that are objects solely defined by a `$ref` keyword and to find and compose schemas from the new `metadata` folder. The change includes the rename for the `requiredSecurityContext` metadata property to `securityContext`.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 18, 2024
This changes defines the metadata properties that DSC returns in the results for the `dsc config *` commands, as implemented in PowerShell#405. It defines each metadata property as a separate file in a new folder for metadata schemas for easier reuse, as well as two definitions of the `metadata` property used across different result objects, one for the top-level of a configuration and one for resource instances in that result. This change also required a minor fix to the build script to account for array items that are objects solely defined by a `$ref` keyword and to find and compose schemas from the new `metadata` folder. The change includes the rename for the `requiredSecurityContext` metadata property to `securityContext`.
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Apr 18, 2024
This changes defines the metadata properties that DSC returns in the results for the `dsc config *` commands, as implemented in PowerShell#405. It defines each metadata property as a separate file in a new folder for metadata schemas for easier reuse, as well as two definitions of the `metadata` property used across different result objects, one for the top-level of a configuration and one for resource instances in that result. This change also required a minor fix to the build script to account for array items that are objects solely defined by a `$ref` keyword and to find and compose schemas from the new `metadata` folder. The change includes the rename for the `requiredSecurityContext` metadata property to `securityContext`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Use metadata to add execution information as part of result. Resource execution now also includes the duration of execution. Resource version will be a top level property in a separate PR.
PR Context
FIx #401