Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Markdown test: node_modules is not able to be deleted when path contains an apostrophe #166

Closed
johlju opened this issue Jul 23, 2017 · 2 comments

Comments

@johlju
Copy link
Contributor

johlju commented Jul 23, 2017

The node_modules is not able to be deleted when path contains an apostrophe. This is because the package 'rimraf' that is used to delete the folder does not support it.
It is also deprecated; https://www.npmjs.com/package/gulp-rimraf.

I'm working on a fix for this. I had code previously in xSQLServer that installed and uninstalled all packages. Then there is no need for the package.json file either. I will send in a PR proposing a change to the markdown common test.

@johlju
Copy link
Contributor Author

johlju commented Jul 23, 2017

Note, if the node_modules is not remove. The second run of Invoke-Pester will incorrectly test a lot of files in the nodes_modules folder.

johlju added a commit to johlju/DscResource.Tests that referenced this issue Jul 23, 2017
Fixed the markdown test so that node_modules can be deleted when path contains an apostrophe (issue PowerShell#166).
@johlju
Copy link
Contributor Author

johlju commented Jul 23, 2017

This hopefully helps to resolve issue PowerShell/DscResources#287.

johlju added a commit to johlju/DscResource.Tests that referenced this issue Jul 25, 2017
Fixed the markdown test so that node_modules can be deleted when path contains an apostrophe (issue PowerShell#166).
johlju added a commit to johlju/DscResource.Tests that referenced this issue Aug 8, 2017
Fixed the markdown test so that node_modules can be deleted when path contains an apostrophe (issue PowerShell#166).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant