Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Run common tests on DscResource.Tests repository #170

Closed
johlju opened this issue Jul 24, 2017 · 5 comments
Closed

Run common tests on DscResource.Tests repository #170

johlju opened this issue Jul 24, 2017 · 5 comments
Assignees
@kwirkykat

Comments

@johlju
Copy link
Contributor

johlju commented Jul 24, 2017

I think we need to add so that we run common tests on this repository. This would prevent issue like #169.
@PlagueHO
Copy link
Collaborator

Yep - agreed. I think we'd also want to implement a really basic AppVeyor.yml file to run the validation checks.

@johlju
Copy link
Contributor Author

johlju commented Jul 25, 2017

I working on this. See if I can fix this. :)

johlju added a commit to johlju/DscResource.Tests that referenced this issue Jul 25, 2017
@johlju
Changes to DscResource.Tests
1ccb2ef 
- Added so that DscResource.Tests is testing it self with it's own common tests (issue PowerShell#170).
@johlju
Copy link
Contributor Author

johlju commented Jul 25, 2017

I have found a solution to use DscResource.Tests to test it self. But I have to get some changes in for this to work. So I will send in two PR's.

  • The first PR will change the code so it is possible for the second PR to pass the tests . Just minor fixes.
  • The second PR will actually be the one that enables the testing, by adding an AppVeyor.yml.

johlju added a commit to johlju/DscResource.Tests that referenced this issue Jul 25, 2017
@johlju
Changes to DscResource.Tests
65b0f18 
- Added so that DscResource.Tests is testing it self with it's own common tests (issue PowerShell#170).
- Change README.md to resolve lint error MD029 and MD036.
- Added module manifest for manifest common tests to pass.
johlju added a commit to johlju/DscResource.Tests that referenced this issue Jul 25, 2017
@johlju
Changes to DscResource.Tests
428b23f 
- Added so that DscResource.Tests is testing it self with it's own common tests (issue PowerShell#170).
- Change README.md to resolve lint error MD029 and MD036.
- Added module manifest for manifest common tests to pass.
johlju added a commit to johlju/DscResource.Tests that referenced this issue Jul 25, 2017
@johlju
Changes to DscResource.Tests
3a4ec45 
- Added so that DscResource.Tests is testing it self with it's own common tests (issue PowerShell#170).
- Change README.md to resolve lint error MD029 and MD036.
- Added module manifest for manifest common tests to pass.
@johlju johlju mentioned this issue Jul 25, 2017
Merged
@johlju
Copy link
Contributor Author

johlju commented Jul 25, 2017

@kwirkykat is it possible to turn on AppVeyor for this repo so that PR #175 can work?

@johlju
Copy link
Contributor Author

johlju commented Jul 25, 2017

@mbreakey3 is it possible to turn on AppVeyor for this repo so that PR #175 can work?

@kwirkykat kwirkykat self-assigned this Jul 27, 2017
johlju added a commit to johlju/DscResource.Tests that referenced this issue Jul 29, 2017
@johlju
Changes to DscResource.Tests
8c2c763 
- Added so that DscResource.Tests is testing it self with it's own common tests (issue PowerShell#170).
- Change README.md to resolve lint error MD029 and MD036.
- Added module manifest for manifest common tests to pass.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kwirkykat kwirkykat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kwirkykat @johlju @PlagueHO