Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

ConvertTo-SpaceIndentation Breaks Files in Some Cases #4

Closed
mhendric opened this issue Jul 10, 2015 · 3 comments
Closed

ConvertTo-SpaceIndentation Breaks Files in Some Cases #4

mhendric opened this issue Jul 10, 2015 · 3 comments
Labels
bug The issue is a bug.

Comments

@mhendric
Copy link
Contributor

Recently when I submitted a pull request for changes to the xExchange module, the automated tests failed on a couple files, and suggested running Get-TextFilesList | ConvertTo-SpaceIndentation to fix them. I decided to run this against the entire module, instead of just the files it suggested. After doing so and resubmitting the pull request, I got failures in multiple files that weren't otherwise modified other than running these commands against them. The failures are reported here:

https://ci.appveyor.com/project/PowerShell/xexchange/build/1.0.35

One of the files that broke is located here:

https://github.com/PowerShell/xExchange/blob/dev/DSCResources/MSFT_xExchMailboxDatabase/MSFT_xExchMailboxDatabase.psm1

@vors vors self-assigned this Jul 10, 2015
@kwirkykat kwirkykat added the bug The issue is a bug. label Aug 3, 2016
@vors vors removed their assignment Sep 6, 2016
@vors
Copy link
Contributor

vors commented Sep 6, 2016

Sorry, didn't have a chance to look at it. I'm clearing the assignee, since I'm not actively working on DscResources at the moment.

@johlju
Copy link
Contributor

johlju commented Jul 11, 2017

@kwirkykat The helper function ConvertTo-SpaceIndentation doesn't seem to exists anymore. But it's referenced in the test here https://github.com/PowerShell/DscResource.Tests/blob/dev/Meta.Tests.ps1#L94

Should we replace the text 'ConvertTo-SpaceIndentation' with something else, , or should be create a fixer function again, or should we remove the sentence entirely from the test? I suggest removing the text.

@kwirkykat
Copy link
Member

@johlju I agree. Just remove the text

johlju added a commit to johlju/DscResource.Tests that referenced this issue Jul 12, 2017
… the warning message in the test that checks for tabs in module files. The function ConvertTo SpaceIndentation does not exist anymore (issue PowerShell#4).
johlju added a commit to johlju/DscResource.Tests that referenced this issue Jul 12, 2017
Removed the reference to the function ConvertTo-SpaceIndentation from the warning message in the test that checks for tabs in module files. The function ConvertTo SpaceIndentation does not exist anymore (issue PowerShell#4).
johlju added a commit to johlju/DscResource.Tests that referenced this issue Jul 13, 2017
Removed the reference to the function ConvertTo-SpaceIndentation from the warning message in the test that checks for tabs in module files. The function ConvertTo SpaceIndentation does not exist anymore (issue PowerShell#4).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug The issue is a bug.
Projects
None yet
Development

No branches or pull requests

4 participants