Restore-TestEnvironment remains PSModulePath added by Initialize-TestEnvironment

[guitarrapc]

Description of Issue

Restore-TestEnvironment could not handle Initialize-TestEnvironment added path.

Detail

Initialize-TestEnvironment adding current Test DSC Module's Root Path, which retrieved at here https://github.com/PowerShell/DscResource.Tests/blob/dev/TestHelper.psm1#L347, to the Machine's PSmodulePath at https://github.com/PowerShell/DscResource.Tests/blob/dev/TestHelper.psm1#L376

It's trying to pass $OldModulePath info, https://github.com/PowerShell/DscResource.Tests/blob/dev/TestHelper.psm1#L393 but ModuleRoot is remain afterRestore-TestEnvironment has ran.

Expectation

Should completely remove Test Module Path from PSModulePath.

[johlju]

Not sure this is still an issue, but let's keep this issue until we have written a unit/integration test for this.

[johlju]

We should add a new test case for this, and Assert-MockCalled here, so that Set-PSModulePath is called with the correct path.

DscResource.Tests/Tests/Unit/TestHelper.Tests.ps1

Line 993 in 4d8376d

{ Restore-TestEnvironment -TestEnvironment $TestEnvironment } | Should -Not -Throw