Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Resolves #31, Added test and fixer for text files ending with new lines #33

Merged
merged 3 commits into from
Mar 24, 2016

Conversation

dcrreynolds
Copy link
Contributor

No description provided.

@msftclas
Copy link

Hi @dcrreynolds, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (David Reynolds). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@PlagueHO
Copy link
Contributor

I like this! LGTM.

@vors
Copy link
Contributor

vors commented Feb 24, 2016

LGTM. But we need to make sure all current repos are passing this test, before merging it.

Would be good to have a comment about motivation for this test, so people can read explanation. In the form of comment on the test, or maybe inside the warning text, ever works.

@dcrreynolds
Copy link
Contributor Author

Would something like the sample output below provide enough detail? A tool could be made that would run the test in this repo against the existing DSC resources to help us determine what would fail when we update the test.

WARNING: To improve consistency across multiple environments and editors each text file is required to end with a new line.
WARNING: C:\example.ps1 does not end with a new line. Use Fixer 'Add-NewLine'

@KarolKaczmarek
Copy link
Contributor

we have module for running all tests here: https://github.com/PowerShell/DscResource.Tests/blob/master/TestRunner.psm1

Proposed warning looks good

@TravisEz13
Copy link
Member

Sorry I merged this change but then reverted it. This might break projects that are currently passing.

  1. We could run it on everything and fix all the issues
  2. Add the test, make it always pass but print a warning. After we think we have fixed enough of the projects

@KarolKaczmarek
Copy link
Contributor

@dcrreynolds Could you run all the tests (script in my previous comment) to see how many modules need to be fixed and provide the list here? Fixing those should be pretty quick. Feel free to resend this PR since we can't reopen it after reverting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants