Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Update DscResource.Template with .gitattributes #420

Closed
johlju opened this issue Jul 23, 2018 · 0 comments · Fixed by #429
Closed

Update DscResource.Template with .gitattributes #420

johlju opened this issue Jul 23, 2018 · 0 comments · Fixed by #429
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Contributor

johlju commented Jul 23, 2018

Instead of these rows in the appveyor.yml

DscResources/DscResource.Template/appveyor.yml

Lines 27 to 29 in 1b35825

init:
# Needed for publishing of examples, build worker defaults to core.autocrlf=input.
- git config --global core.autocrlf true

I suggest we update the resource template to use a .gitattributes file with the same, so that the correct line endings is always used regardless of where the repository is checked out.

https://github.com/PowerShell/DscResource.Tests/blob/dev/.gitattributes
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jul 23, 2018
johlju added a commit to johlju/DscResources that referenced this issue Aug 3, 2018
@johlju
Update DscResource.Template with .gitattributes (issue PowerShell#420)
38f0035
@johlju johlju mentioned this issue Aug 3, 2018
Merged
5 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Aug 3, 2018
johlju added a commit that referenced this issue Aug 27, 2018
@johlju
Update DscResource.Template and (Unit) Test.Template (#429)
0d4c7fc 
- Update Tests.Template
  - Added example of placement of mocks to the unit test template (issue #425).
- Update DscResource.Template
  - Added localization template for the example resource.
  - Added an example module in a new Modules folder (issue #428)
  - Update DscResource.Template with .gitattributes, removes the need for the `init` key in appveyor.yml (issue #420).
  - Removed duplicate status badge example.
  - Added an example of version history in CHANGELOG.md.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update DscResource.Template and (Unit) Test.Template johlju/DscResources
1 participant
@johlju