Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double doublequotes in here-string scopes as a character.escape #143

Closed
msftrncs opened this issue Aug 25, 2018 · 1 comment · Fixed by #173
Closed

Double doublequotes in here-string scopes as a character.escape #143

msftrncs opened this issue Aug 25, 2018 · 1 comment · Fixed by #173

Comments

@msftrncs
Copy link
Contributor

Environment

  • Editor and Version: VS Code: 1.26.1
  • Your primary theme: Monokai Dimmed

Issue Description

Doubled doublequotes in here-string is scoped as a character escape.

image

Expected Behavior

Doubled doublequotes are not any kind of an escaped character in a here-string.

image

Code Samples

@"
Hello There
""Doubled DoubleQuotes""
"@
@msftrncs
Copy link
Contributor Author

msftrncs commented Aug 25, 2018 •
edited

Single quote here-string has similar problem, treats double single-quotes as character escape, where there are no valid character escapes in a single-quoted here-string.

@msftrncs msftrncs mentioned this issue Apr 28, 2019
Closed
msftrncs added a commit to msftrncs/EditorSyntax that referenced this issue Apr 28, 2019
@msftrncs
fixes PowerShell#143
f155a23 
moves double-quote double-quote escape from #doubleQuotedStringEscapes
to #doubleQuotedString.  Removes the single-quote single-quote escape
from single-quote here-string pattern.
@msftrncs msftrncs mentioned this issue Apr 28, 2019
Closed
@msftrncs msftrncs mentioned this issue May 8, 2019
Merged
msftrncs added a commit to msftrncs/EditorSyntax that referenced this issue May 9, 2019
@msftrncs
fixes PowerShell#143
945aec7 
moves double-quote double-quote escape from #doubleQuotedStringEscapes
to #doubleQuotedString.  Removes the single-quote single-quote escape
from single-quote here-string pattern.
msftrncs added a commit to msftrncs/EditorSyntax that referenced this issue May 9, 2019
@msftrncs
tests for PowerShell#143
bcb295e
msftrncs added a commit to msftrncs/EditorSyntax that referenced this issue May 9, 2019
@msftrncs
fixes PowerShell#143
370d0c1 
moves double-quote double-quote escape from #doubleQuotedStringEscapes
to #doubleQuotedString.  Removes the single-quote single-quote escape
from single-quote here-string pattern.
msftrncs added a commit to msftrncs/EditorSyntax that referenced this issue May 9, 2019
@msftrncs
tests for PowerShell#143 and PowerShell#167 part 1
bb41692
@msftrncs msftrncs mentioned this issue May 9, 2019
Merged
@justinytchen justinytchen mentioned this issue Jul 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and enhance mulitple quoted string issues msftrncs/EditorSyntax
1 participant
@msftrncs