Fix correct way to get substring based on buffercells when encountering CJK chars #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzybkr
reviewed
Oct 15, 2019
lzybkr
reviewed
Oct 15, 2019
lzybkr
approved these changes
Oct 16, 2019
daxian-dbw
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was correctly calculating the number of buffer cells for CJK chars, but then used substring() to get a substring which failed as the number of cells is > number of chars. Fix is to have a SubstringByCells() method that understands how to return substring based on cells. Also using unicode ellipsis char instead of
...to save screen space.Tried to add a unittest, but couldn't get the CJK char to work with KeyboardLayout.
Fix #847