Utilize LengthInBufferCells when creating Completions Menu #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use LengthInBufferCells() for determining the display width of menu items in CreateCompletionMenu() to correct support of CJK characters in completion items. Fixes PowerShell#1213.
Remove ShortenLongCompletions() as it appears to be unused and would not correctly support CJK characters in completion items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stage of analysis of the width of each completion item to determine the width of the columns of items in the completion menu did not account for buffer cells as consumed by CJK characters.
This corrects that.
This also removes
ShortenLongCompletions, as it appears to be discontinued code, and also would not support CJK characters in completion items without modifications.This fixes #1213, and maybe others.