Correct cursor positioning issues #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct cursor positioning in cases where newline appears 1 character before last column, or a CJK character ends the line but wraps to next display line, and in cases where continuation prompt contains either CJK characters, or VT color sequences. Fixes PowerShell#1216. Fixes PowerShell#1217. Fixes PowerShell#1188.
|
I am thinking I should be able to generate some tests for these conditions (at least 1216 and 1217), but I am not sure where they should be placed? Does the test console correctly support double-width characters? |
|
I don't think the test framework knows anything about double width characters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct cursor positioning in cases where newline appears 1 character before last column, or a CJK character ends the line but wraps to next display line, and in cases where continuation prompt contains either CJK characters, or VT color sequences.
Fixes #1216.
Fixes #1217.
Fixes #1188.
This does simplify some X calculations, that I didn't have to touch, but they were more complicated than they needed to be.