Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the inline prediction to not leak color beyond the suggestion text #1861

Merged
merged 1 commit into from Oct 7, 2020

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Oct 7, 2020

PR Summary

Fix the inline prediction to not leak color beyond the suggestion text.

When setting the prediction color to be 'foreground/background inverted', you will see the color setting gets leaked:

image

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit 0c649bf into PowerShell:master Oct 7, 2020
@daxian-dbw daxian-dbw deleted the color-leak branch October 7, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant