Allow 'MaximumHistoryCount' to be set from user's profile #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzybkr
approved these changes
Oct 9, 2020
|
Having set both, $MaximumHistoryCount and readline's -MaximumHistoryCount doesn't work for a non-default -HistorySavePath; both values are set to 4096, yet the number of entries in the history file is bigger than 30000. Versions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #1781
Allow 'MaximumHistoryCount' to be set from user's profile.
Fix
DelayedOneTimeInitialize()to initialize theMaximumHistoryCountonly if it's not already defined (by user's profile, beforeReadLineis called).PR Checklist
Microsoft Reviewers: Open in CodeFlow