Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LineIsMultiline in favor of multiline agnostic algorithms (#1125) #2047

Merged
merged 4 commits into from Feb 11, 2021
Merged

Remove LineIsMultiline in favor of multiline agnostic algorithms (#1125) #2047

merged 4 commits into from Feb 11, 2021

Conversation

springcomp
Copy link
Contributor

@springcomp springcomp commented Dec 17, 2020 •
edited by ghost

PR Summary

Fixes #1125.

This PR removes as many calls as possible of the method LineIsMultiline() where the underlying algorithm is already behaving consistently irrespective of the number of logical lines in the buffer.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests - All non-regression changes covered by existing unit-tests.
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
Microsoft Reviewers: Open in CodeFlow

@springcomp springcomp mentioned this pull request Dec 17, 2020
Open
daxian-dbw
daxian-dbw requested changes Jan 8, 2021
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to elide the unneeded LineIsMultiLine() check. I left a few comments.

PSReadLine/BasicEditing.cs Outdated Show resolved Hide resolved
PSReadLine/Movement.vi.cs Show resolved Hide resolved
PSReadLine/Movement.vi.cs Show resolved Hide resolved
PSReadLine/Movement.vi.multiline.cs Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author Feedback label Jan 8, 2021
@ghost ghost removed the Needs-Author Feedback label Jan 19, 2021
@daxian-dbw daxian-dbw mentioned this pull request Feb 10, 2021
Merged
5 tasks
@daxian-dbw
Copy link
Member

daxian-dbw commented Feb 10, 2021 •
edited

@springcomp I apologize for taking so long to get back to this.
I rebased your branch against master, and left 2 comments above. If you agree with my comments, I can help make the according changes.

@springcomp
Copy link
Contributor Author

No worries. I will address the changes.
Thank you for your help.

@ghost ghost removed the Needs-Author Feedback label Feb 10, 2021
daxian-dbw
daxian-dbw approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @springcomp!

@daxian-dbw daxian-dbw merged commit 0de6368 into PowerShell:master Feb 11, 2021
@springcomp springcomp deleted the #1125 branch February 12, 2021 00:21
@ghost
Copy link

ghost commented Feb 23, 2021

🎉 v2.2.0-beta2 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor code efficiency issue, use of LineIsMultiLine()
2 participants
@springcomp @daxian-dbw