Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a null-ref exception in DynamicHelpImpl #2292

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Fix a null-ref exception in DynamicHelpImpl #2292

merged 2 commits into from
Mar 11, 2021

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Mar 11, 2021 •
edited

PR Summary

Fix #2283
Fix a null-ref exception in DynamicHelpImpl.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit dc38b45 into PowerShell:master Mar 11, 2021
@daxian-dbw daxian-dbw deleted the null-ref branch March 11, 2021 17:14
@ghost
Copy link

ghost commented Jun 1, 2021

🎉 v2.2.0-beta3 has been released which incorporates this pull request. 🎉

@daxian-dbw daxian-dbw mentioned this pull request Oct 25, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic Help - NullReferenceException in Powershell 7.2.0-preview.3 and Windows Powershell 5.1.19041.610
2 participants
@daxian-dbw @adityapatwardhan