Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the cancellation token along instead of using the default one #2636

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Pass the cancellation token along instead of using the default one #2636

merged 1 commit into from
Jul 1, 2021

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jul 1, 2021 •
edited by ghost

PR Summary

Fix #2616

This is an oversight. The cancellationToken should be passed along instead of the default token.
This overload was added to keep backward compatibility for PSES.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw requested a review from rjmholt July 1, 2021 18:06
@daxian-dbw daxian-dbw mentioned this pull request Jul 1, 2021
Closed
andyleejordan
andyleejordan approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@daxian-dbw daxian-dbw merged commit bc485e0 into PowerShell:master Jul 1, 2021
@daxian-dbw daxian-dbw deleted the typo branch July 1, 2021 23:10
@andyleejordan andyleejordan mentioned this pull request Jul 12, 2021
Closed
@ghost
Copy link

ghost commented Oct 28, 2021

🎉 v2.2.0-beta4 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

@rjmholt rjmholt rjmholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrading from 2.2.0-beta2 > beta3 broke Powershell debugger in vscode
3 participants
@daxian-dbw @andyleejordan @rjmholt