Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'BasicScrollingConsole' to support test cases for scrolling up scenarios #3081

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Dec 4, 2021

PR Summary

The major changes included are:

  1. Add BasicScrollingConsole along with other testing infrastructure improvements to support tests cases for scrolling up scenarios.
  2. Add test cases to cover some fixes to bugs related to scrolling up scenarios:
  3. Fixed another scrolling up issue in menu completion, which I discovered while working on the tests.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw
Copy link
Member Author

@andschwa Can you please do a review for me? Thanks!

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very extension test updates and a good edge case fix, I like it!

@daxian-dbw daxian-dbw merged commit b768836 into PowerShell:master Dec 14, 2021
@daxian-dbw daxian-dbw deleted the testinfra branch December 14, 2021 23:14
@ghost
Copy link

ghost commented Jan 7, 2022

🎉 v2.2.0-beta5 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants