Make Ctrl+r in Vi edit mode same as Emacs edit mode
#3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing functionality (ViSearchHistoryBackward, SearchForward) is already available via / and ? shortcuts. But ReverseSearchHistory and ForwardSearchHistory had no none. Also copied Ctrl+S and Ctrl+G since these had no conflicts in vi mode. Removed vi mode existing tests and copied (almost) verbatim from InteractiveHistorySearch to VIInteractiveHistorySearch. Omitted test which uses _.Alt_d from VIInteractiveHistorySearch since this is emacs specific.
7 tasks
|
I have reviewed #2469 and the changes looked good to me. I just pushed another commit on top for some test updates. So, I will merge this PR now. Thanks @davetapley for your contribution! |
daxian-dbw
changed the title
Vi edit mode same as Emacs edit modeCtrl+r in Vi edit mode same as Emacs edit mode
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR is essentially the same as #2469, with a little update on the tests.
Fix #2453
Make ctrl+r in Vi
EditModesame as Windows (#2453)Existing functionality (
ViSearchHistoryBackward,SearchForward) already available via / and ? shortcuts.But
ReverseSearchHistoryandForwardSearchHistoryhad no shortcuts.Also copy ctrl+s and ctrl+g since these have no conflicts in vi mode.
Remove vi mode existing tests and copy (almost) verbatim from
InteractiveHistorySearchtoVIInteractiveHistorySearch.PR Checklist
Microsoft Reviewers: Open in CodeFlow