Fix to force refreshing suggestion in the inline view when plugin is in use #3644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix to force refreshing suggestion in the inline view when plugin is in use, even if the current history suggestion can still apply to the new input.
Scenario:
When the prediction source is
HistoryAndPlugin
, we favor plugin results over history results in the inline view. For an command-line input, if the plugin doesn't return anything, the history result will be used.Today, when an inline view prediction is displayed, if you keep typing and the existing suggestion can still apply to the resulted new input, PSReadLine will continue to use the existing suggestion text instead of refreshing the suggestion.
So, when the history suggestion is used for inline view, if the new input resulted from your typing can still fit in the existing history suggestion, the plugin won't be triggered, even though it now may return more relevant result.
This PR fixes the above issue:
History
only, the behavior is not changedHistoryAndPlugin
PR Checklist
Microsoft Reviewers: Open in CodeFlow