-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TerminateStragglers option (Windows) #3764
Merged
daxian-dbw
merged 8 commits into
PowerShell:master
from
jazzdelightsme:user/danthom/terminateStragglers
Aug 9, 2023
Merged
Add TerminateStragglers option (Windows) #3764
daxian-dbw
merged 8 commits into
PowerShell:master
from
jazzdelightsme:user/danthom/terminateStragglers
Aug 9, 2023
Commits on Jul 30, 2023
-
Add TerminateStragglers option (Windows)
Addresses PowerShell#3745 There is a lot more detail about the problem this PR solves in the code comments and the linked Issue. In short, this PR: * Adds a new "TerminateStragglers" option. * When enabled, existing console-attached PIDs are gathered into an "allow" list (on Windows only). * When the shell informs us that it is time to wait for input, right before we disable ctrl+c signals, (if enabled) we ensure that the shell will not be broken by other console-attached children that may also be attempting to read input. How tested: added printfs and manually triggered the problem scenario, to verify that the code works as expected. There are a few open questions; I will leave some comments in the PR (for example: if someone on non-Windows enables the option, should we write a warning, or just smile and accept it?).
Configuration menu - View commit details
-
Copy full SHA for e273150 - Browse repository at this point
Copy the full SHA e273150View commit details
Commits on Jul 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9ae1995 - Browse repository at this point
Copy the full SHA 9ae1995View commit details
Commits on Aug 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ea01977 - Browse repository at this point
Copy the full SHA ea01977View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60aeaba - Browse repository at this point
Copy the full SHA 60aeabaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8c6605 - Browse repository at this point
Copy the full SHA b8c6605View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f30902 - Browse repository at this point
Copy the full SHA 0f30902View commit details
Commits on Aug 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8ba11a2 - Browse repository at this point
Copy the full SHA 8ba11a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b2c825 - Browse repository at this point
Copy the full SHA 2b2c825View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.