Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TerminateStragglers option (Windows) #3764

Merged

Commits on Jul 30, 2023

  1. Add TerminateStragglers option (Windows)

    Addresses PowerShell#3745
    
    There is a lot more detail about the problem this PR solves in the code
    comments and the linked Issue. In short, this PR:
    
    * Adds a new "TerminateStragglers" option.
    * When enabled, existing console-attached PIDs are gathered into an
      "allow" list (on Windows only).
    * When the shell informs us that it is time to wait for input, right
      before we disable ctrl+c signals, (if enabled) we ensure that the
      shell will not be broken by other console-attached children that may
      also be attempting to read input.
    
    How tested: added printfs and manually triggered the problem scenario,
    to verify that the code works as expected.
    
    There are a few open questions; I will leave some comments in the PR
    (for example: if someone on non-Windows enables the option, should we
    write a warning, or just smile and accept it?).
    jazzdelightsme committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    e273150 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    9ae1995 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. PR feedback

    jazzdelightsme committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    ea01977 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    60aeaba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b8c6605 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0f30902 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Configuration menu
    Copy the full SHA
    8ba11a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b2c825 View commit details
    Browse the repository at this point in the history