Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing curly quotes in check functions #985

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

msftrncs
Copy link
Collaborator

This adds the quotes `u{201B} (single curly quote) and `u{201E} (double curly quote), as they seem to have been left out, so this makes the check functions complete with regards to PowerShell syntax.

However, I am not sure that any active code currently reaches these quotes, as the completion code in PowerShell replaces curly quotes with their standard variation.

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daxian-dbw daxian-dbw merged commit 3ed06e1 into PowerShell:master Jul 31, 2019
@msftrncs msftrncs deleted the AddMissingQuotes branch September 7, 2019 03:57
@daxian-dbw daxian-dbw added this to the 2.0.0-beta5 milestone Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants