Mark setting files as content for easier out-of-the-box debugging #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
changed the title
JamesWTruher
approved these changes
Dec 6, 2018
|
once the build is fixed, then go ahead and merge |
…nalyzer into SettingFilesRefactoring
bergmeister
added a commit
to bergmeister/PSScriptAnalyzer
that referenced
this pull request
Mar 5, 2019
…werShell#1104) * copy setting files to output for easier debugging against ps v5 * trigger ci
bergmeister
added a commit
to bergmeister/PSScriptAnalyzer
that referenced
this pull request
Mar 22, 2019
…werShell#1104) * copy setting files to output for easier debugging against ps v5 * trigger ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Whenever I want to attach the debugger to a scriptanalyzer command that involves setting files, I have to manually copy the Settings folder into the bin folder. This will ease the process by marking the settings files as content and copying it to the bin folder.
In the future we should also refactor the code to expect the same directory structure for each ps version, which will also enable us later to get rid of the custom code that creates the module structure
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.