Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock calls around Test-ModuleManifest, which is not thread safe #1258

Merged

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Jun 10, 2019

PR Summary

This is an alternative, better implementation, compared to PR #1257
Basically the issues below show that Test-ModuleManifest exhibits a concurreny problem in all version of PowerShell and it is not clear yet if that is an issue of the cmdlet itself or something deep within SMA. But as a matter of fact, the only way to avoid it at the moment, is not avoid concurrent calls to Test-ModuleManifest.
Please use a whitespace-ignoring diff due to the indentation shift.

Fixes #901
Fixes #902

PR Checklist

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

You may also find that the PSModuleInfo object itself isn't threadsafe, but I'm not sure.

@bergmeister bergmeister changed the title Lock calls around Test-ModuleManifest, which is not thread safe (better alternative to PR #1257) Lock calls around Test-ModuleManifest, which is not thread safe Jun 12, 2019
@bergmeister bergmeister merged commit b09eb33 into PowerShell:development Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants