Lock calls around Test-ModuleManifest, which is not thread safe #1258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is an alternative, better implementation, compared to PR #1257
Basically the issues below show that
Test-ModuleManifest
exhibits a concurreny problem in all version of PowerShell and it is not clear yet if that is an issue of the cmdlet itself or something deep within SMA. But as a matter of fact, the only way to avoid it at the moment, is not avoid concurrent calls toTest-ModuleManifest
.Please use a whitespace-ignoring diff due to the indentation shift.
Fixes #901
Fixes #902
PR Checklist
.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.