Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in rule name output #560

Merged

Conversation

Blackbaud-ShaydeNofziger
Copy link
Contributor

@Blackbaud-ShaydeNofziger Blackbaud-ShaydeNofziger commented Jun 8, 2016

This fix updates a comment and String resource value to fix a typo for the "Use Declared Vars More Than Assignments" rule.


This change is Reviewable

"Assigments" should be "Assignments"
"Assigments" should be "Assignments"
@msftclas
Copy link

msftclas commented Jun 8, 2016

Hi @Blackbaud-ShaydeNofziger, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Jun 8, 2016

@Blackbaud-ShaydeNofziger, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@kapilmb
Copy link

kapilmb commented Jun 8, 2016

@Blackbaud-ShaydeNofziger Thanks for the PR. Can you please fix the failing test cases? Also, can you please the update the instances of "PSUseDeclaredVarsMoreThanAssigments" in Engine/about_PSScriptAnalyzer.help.text. Thanks.

Previously, msftclas (Microsoft Contribution License Agreements) wrote…

@Blackbaud-ShaydeNofziger, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.


Thanks, MSBOT;


Comments from Reviewable

@kapilmb
Copy link

kapilmb commented Jun 8, 2016

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@kapilmb
Copy link

kapilmb commented Jun 8, 2016

The typo is also present in Rules/UseDeclaredVarsMoreThanAssignments.cs.

Previously, kapilmb (Kapil Borle) wrote…

@Blackbaud-ShaydeNofziger Thanks for the PR. Can you please fix the failing test cases? Also, can you please the update the instances of "PSUseDeclaredVarsMoreThanAssigments" in Engine/about_PSScriptAnalyzer.help.text. Thanks.


Comments from Reviewable

@kapilmb
Copy link

kapilmb commented Jun 8, 2016

Reviewed 2 of 2 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@kapilmb
Copy link

kapilmb commented Jun 8, 2016

:lgtm:

Previously, kapilmb (Kapil Borle) wrote…

The typo is also present in Rules/UseDeclaredVarsMoreThanAssignments.cs.


Comments from Reviewable

@kapilmb
Copy link

kapilmb commented Jun 8, 2016

@Blackbaud-ShaydeNofziger Thanks for the contribution.

Resolves #559

@kapilmb kapilmb merged commit 0e287f7 into PowerShell:development Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants