Add PowerShell Core Build+Test to Appveyor CI #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veyor environment
…sed this works in WMF as well)
…aningful (again fingers crossed for the WMF 4 build)
…hich have to install the .net sdk from scratch
…image, let's hope it works for WMF 4 as well)
…ion for a Linux build+test (which already works when adding additional Import-Module calls but has 13 failing tests)
7 tasks
JamesWTruher
approved these changes
Mar 20, 2018
| @@ -83,7 +83,7 @@ Describe "UseManifestExportFields" { | |||
| $results[0].Extent.Text | Should -Be "'*'" | |||
| } | |||
|
|
|||
| It "suggests corrections for AliasesToExport with wildcard" -pending:($IsLinux -or $IsMacOS) { | |||
| It "suggests corrections for AliasesToExport with wildcard" -pending:($IsCoreClr) { | |||
There was a problem hiding this comment.
is this tracked by an issue?
There was a problem hiding this comment.
No but Pester shows the number of pending tests. We should maybe create an issue specific for the non-Windows builds and fix/investigate it as part of making the non-Windows builds?
There was a problem hiding this comment.
I created an issue here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Build PSSA and run CI tests using PowerShell Core (on Windows) in addition to the existing WMF4 and WMF5 runs.
I should also note that on my dev machine (Win10) 9 tests are always failing when being run using pwsh, hence I usually run the tests locally only using Windows PowerShell, therefore this PR will also be helpful for me not having to always run tests twice and filter out the actual from the expected failures.
Another image in the matrix was added and since AppVeyor does not seem to support conditional tasks, either a ps and pwsh task executes the action depending on the chosen image env variable.
Therefore scripts were unified in a new appveyor.psm1 module (to be consistent with PSCore) with the exception of the test scripts because they behaved differently when being run from the function defined in the module (12 failures in Windows PowerShell and PowerShell Core).
The scripts were enhanced to be more generic, hard-coded paths were removed and now only the usage of
nuget installandPush-AppveyorArtifactis AppVeyor specific, therefore this should serve as a good base for running tests on non-Windows environments (on Appveyor or Travis). I requested access to AppVeyor's private beta program for Linux builds in the meantime, which I got enabled for this repo and my account. Apart from addingImport-Module .\tools\appveyor.psm1calls, the current configuration already works on the Linux image but since there are 13 failures, the Linux build should be a different PR.One series of tests had to be adapted to work on pwsh and 1 test was made pending (it was already pending for mac and linux).
The white-listing of branches to build was removed to allow running the appveyor builds in other forked branches as well.
I'll try to reduce the number of PRs after this a bit to give you more time for finishing off what is required for the next release. I added the
1.17milestone to PRs that I think are worthwhile considering to get into the next release.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.NAUser facing documentation neededNAMake sure you've added a new test if existing tests do not effectively test the code changedWIP:to the beginning of the title and remove the prefix when the PR is ready