Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing additional files in PR #96 for Photon image #101

Merged
merged 16 commits into from
Dec 13, 2018
Merged

Fix missing additional files in PR #96 for Photon image #101

merged 16 commits into from
Dec 13, 2018

Conversation

kiazhi
Copy link
Contributor

@kiazhi kiazhi commented Dec 13, 2018

PR Summary

Found out that PR #96 merged without some of the additional files and config in yml.

  • Add Photon Tags JSON
  • Add Photon Meta JSON
  • Add Photon getLatestTag PowerShell script
  • Update Photon to vsts-ci.yml
  • Update powershell community README

PR Checklist

@kiazhi
Copy link
Contributor Author

kiazhi commented Dec 13, 2018

CentOS7 Stable failed. Probably need to re-trigger the job again

@kiazhi kiazhi changed the title Fix missing additional files in PR #96 Fix missing additional files in PR #96 for Photon image Dec 13, 2018
@TravisEz13
Copy link
Member

Could you fix the Display names in the YAML file? Line 40 should be stable instead of servicing. Line 45 should be preview instead of servicing. It's just an annoyance but...

displayName: $(ImageName) Servicing
condition: succeededOrFailed()
- ${{ if eq(parameters.communityPreview, 'true') }}:
- powershell: ./build.ps1 -build -name '$(ImageName)' -CI -Channel 'community-preview' -TestLogPostfix '$(ImageName)-servicing'
displayName: $(ImageName) Servicing
condition: succeededOrFailed()
- ${{ if eq(parameters.communityServicing, 'true') }}:
- powershell: ./build.ps1 -build -name '$(ImageName)' -CI -Channel 'community-servicing' -TestLogPostfix '$(ImageName)-servicing'
displayName: $(ImageName) Servicing

@TravisEz13
Copy link
Member

Your CI failed due to a random failure in the centos image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants