Separate nanoserver 1809 due to breaking change
#118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
northtyphoon
reviewed
Jan 8, 2019
| @@ -0,0 +1,56 @@ | |||
| # escape=` | |||
| # Args used by from statements must be defined here: | |||
| ARG fromTag=1709 | |||
There was a problem hiding this comment.
How do you make sure fromTag and WindowsServerCoreVersion are based the same os version (eg, ltsc2019)?
There was a problem hiding this comment.
They don't need to be. So I don't
There was a problem hiding this comment.
latest is supposed to be a manifestlist that works on the current platform. So, I used that. But, after they moved to mcr, it's no longer a manifestlist. I deal with the problem of incompatible kernels if I ever hit it.
anmenaga
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Separate
nanoserver 1809due to breaking changeSETXno longer works to set environment variable so 1809 has to be separate at least from1709whereENVdid not work for thePATHvariable.nanoservertag queryFixes #89
PR Checklist
Dockerfile,.sh,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.