Add Windows 20H2 images #523

vboulineau · 2021-01-05T14:28:14Z

PR Summary

Add images based on Windows 20H2 images.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all Dockerfile, .sh, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
Adds a new image or tag
- Not Applicable
OR
- Update README.powershellcommunity.md
- Update vsts-ci.yml

ghost · 2021-01-05T14:28:29Z

All CLA requirements met.

RDIL

Hey @vboulineau,
I looked over the PR and found a few things to note, so here they are.
Thanks for the contribution!

RDIL · 2021-01-05T14:34:51Z

release/lts/nanoserver20H2/dependabot/Dockerfile

@@ -3,4 +3,4 @@

 # Dummy docker image to trigger dependabot PRs

-FROM mcr.microsoft.com/windows/nanoserver:2004


I feel like nano 2k4 should be kept for LTS, and only introduce this new version in stable and preview channels, since it is new. Even if the LTS supports it, it seems like its a bit late in the LTS lifespan to introduce a new OS version now.

This change is fine, as long as 2004 image is not deleted

RDIL · 2021-01-05T14:35:57Z

release/servicing/nanoserver1809/meta.json

@@ -14,6 +14,9 @@
        },
        {
            "Tag": "2004"
+        },
+        {
+            "Tag": "20H2"


Same here, this is servicing. We should not have it here 100%, but maybe for LTS if @TravisEz13 agrees.

Works for me, removed for servicing. Pending review for LTS.

TravisEz13

Pending test run

TravisEz13 · 2021-01-15T18:25:45Z

release/lts/nanoserver20H2/dependabot/Dockerfile

@@ -3,4 +3,4 @@

 # Dummy docker image to trigger dependabot PRs

-FROM mcr.microsoft.com/windows/nanoserver:2004


This change is fine, as long as 2004 image is not deleted

TravisEz13 · 2021-01-15T18:28:14Z

/azp list

azure-pipelines · 2021-01-15T18:28:19Z

CI/CD Pipelines for this repository: docker-PR docker-ACR-CI

TravisEz13 · 2021-01-15T18:28:35Z

/azp run docker-ACR-CI

azure-pipelines · 2021-01-15T18:28:47Z

Azure Pipelines successfully started running 1 pipeline(s).

TravisEz13 · 2021-01-15T18:29:25Z

@PoshChan Please remind me in 1 hour

PoshChan · 2021-01-15T19:30:31Z

@TravisEz13, this is the reminder you requested 1 hour ago

luthermonson · 2021-01-15T22:47:17Z

@TravisEz13 we still have a chance of getting this today?

RDIL · 2021-01-16T00:54:27Z

The build is currently failing so no.

vboulineau · 2021-01-18T09:03:08Z

Hello @RDIL @TravisEz13, the failure seems to be due to az acr build --platform windows running at most 10.0.19041 (so 2004).
I am not sure there's a straightforward workaround for this, let me know if there's anything I need to change on my side.

RDIL · 2021-01-18T18:06:04Z

That's not good! I guess we have to wait for Azure then 😢

jeanfrancoislarente · 2021-01-20T19:53:53Z

Ping on this one - would be great to get this soon

RDIL · 2021-01-20T19:58:40Z

Ping on this one - would be great to get this soon

Hey,
I know this is a highly requested feature. We will try to get this out whenever we can.
Sorry for the wait!

RDIL

Requested changes are fixed now

jeanfrancoislarente · 2021-01-20T20:08:08Z

Ping on this one - would be great to get this soon

Hey,
I know this is a highly requested feature. We will try to get this out whenever we can.
Sorry for the wait!

Not complaining, just asking :)

It's important for many who follow the SAC releases closely to have "all the things" follow along as well!

TravisEz13 · 2021-01-22T00:11:59Z

We cannot release until az acr can build 20h2. I'll try again today.

aravindhp · 2021-02-18T23:29:02Z

Gentle ping on this PR

TravisEz13 · 2021-02-20T00:45:08Z

@aravindhp Still waiting on ACR. No current ETA.

TravisEz13 · 2021-03-31T17:02:07Z

The following issue has been filed with ACR to track this: Azure/acr#532

anamnavi

Hi @vboulineau, I added IsBroken tags so we can get this in even though we can't publish these to ACR til we have resolution from that side. If you could pull in changes from upstream master (as your branch is 8 commits behind PowerShell:master) we should be good to merge I believe.

Signed-off-by: Vincent Boulineau <vincent.boulineau@datadoghq.com>

vboulineau · 2021-04-12T14:32:29Z

Hi @vboulineau, I added IsBroken tags so we can get this in even though we can't publish these to ACR til we have resolution from that side. If you could pull in changes from upstream master (as your branch is 8 commits behind PowerShell:master) we should be good to merge I believe.

Done, I guess it will require to manually remove the IsBroken metadata when support is available and finally get a released image.

TravisEz13 · 2021-04-12T17:52:29Z

/azp run docker-ACR-CI

azure-pipelines · 2021-04-12T17:52:38Z

Azure Pipelines successfully started running 1 pipeline(s).

TravisEz13 · 2021-04-12T17:52:48Z

@PoshChan Please remind me in 1 hour

anamnavi

built the images again to test and check and all looks good to me. Tests look good too.

PoshChan · 2021-04-12T18:53:45Z

@TravisEz13, this is the reminder you requested 1 hour ago

anamnavi · 2021-04-12T19:43:51Z

Hi @vboulineau, I added IsBroken tags so we can get this in even though we can't publish these to ACR til we have resolution from that side. If you could pull in changes from upstream master (as your branch is 8 commits behind PowerShell:master) we should be good to merge I believe.

Done, I guess it will require to manually remove the IsBroken metadata when support is available and finally get a released image.

Yes, I'll come back and make those changes to the metadata when support is finally available. Thank you again for the contribution and patience as we figured this out :)

donny-dont · 2021-04-12T19:54:39Z

@anamnavi can we have an issue to follow for when 20H2 support is finally available?

anamnavi · 2021-04-12T20:46:31Z

sure @donny-dont. Here's the issue: #552

TravisEz13 · 2021-04-12T21:14:42Z

I also added a known issue to the wiki.
https://github.com/PowerShell/PowerShell-Docker/wiki/Known-Issues#windows-20h2-images-and-newer

GitHub
PowerShell/PowerShell-Docker
Repository for building PowerShell Docker images. Contribute to PowerShell/PowerShell-Docker development by creating an account on GitHub.

vboulineau requested review from anamnavi and TravisEz13 as code owners January 5, 2021 14:28

RDIL suggested changes Jan 5, 2021

View reviewed changes

ghost added the Waiting on Author label Jan 5, 2021

vboulineau force-pushed the vboulineau/win20h2 branch from ef9e32f to 8f1ed11 Compare January 5, 2021 14:45

ghost removed the Waiting on Author label Jan 5, 2021

RDIL mentioned this pull request Jan 6, 2021

Build and provide Server version 20H2 Image #524

Closed

2 tasks

donny-dont mentioned this pull request Jan 7, 2021

Adding Windows 2004 drone/drone-git#25

Closed

TravisEz13 reviewed Jan 15, 2021

View reviewed changes

RDIL added Issue-Enhancement Waiting on Author labels Jan 16, 2021

ghost removed the Waiting on Author label Jan 18, 2021

RDIL approved these changes Jan 20, 2021

View reviewed changes

luthermonson mentioned this pull request Jan 20, 2021

[v2.5] Windows 20H2 Builds rancher/rancher#30701

Closed

This comment has been minimized.

Sign in to view

TravisEz13 mentioned this pull request Mar 31, 2021

Add support for building on Windows versions AFTER 2004 Azure/acr#532

Closed

This comment has been minimized.

Sign in to view

vboulineau mentioned this pull request Apr 9, 2021

Publish Docker image for Windows version 20H2 DataDog/datadog-agent#7779

Open

anamnavi reviewed Apr 9, 2021

View reviewed changes

vboulineau force-pushed the vboulineau/win20h2 branch from 694b540 to ef72ef2 Compare April 12, 2021 08:11

Add Windows 20H2 images

3569e7d

Signed-off-by: Vincent Boulineau <vincent.boulineau@datadoghq.com>

vboulineau force-pushed the vboulineau/win20h2 branch from ef72ef2 to 3569e7d Compare April 12, 2021 08:19

anamnavi approved these changes Apr 12, 2021

View reviewed changes

anamnavi merged commit 890b315 into PowerShell:master Apr 12, 2021

		@@ -3,4 +3,4 @@

		# Dummy docker image to trigger dependabot PRs

		FROM mcr.microsoft.com/windows/nanoserver:2004

Add Windows 20H2 images #523

Add Windows 20H2 images #523

Conversation

vboulineau commented Jan 5, 2021

PR Summary

PR Checklist

ghost commented Jan 5, 2021 • edited by ghost

RDIL left a comment

Choose a reason for hiding this comment

RDIL Jan 5, 2021

Choose a reason for hiding this comment

TravisEz13 Jan 15, 2021

Choose a reason for hiding this comment

RDIL Jan 5, 2021

Choose a reason for hiding this comment

vboulineau Jan 5, 2021

Choose a reason for hiding this comment

TravisEz13 left a comment

Choose a reason for hiding this comment

TravisEz13 Jan 15, 2021

Choose a reason for hiding this comment

TravisEz13 commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

TravisEz13 commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

TravisEz13 commented Jan 15, 2021

PoshChan commented Jan 15, 2021

luthermonson commented Jan 15, 2021

RDIL commented Jan 16, 2021

vboulineau commented Jan 18, 2021

RDIL commented Jan 18, 2021

jeanfrancoislarente commented Jan 20, 2021

RDIL commented Jan 20, 2021

RDIL left a comment

Choose a reason for hiding this comment

jeanfrancoislarente commented Jan 20, 2021

TravisEz13 commented Jan 22, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

aravindhp commented Feb 18, 2021

TravisEz13 commented Feb 20, 2021

TravisEz13 commented Mar 31, 2021

This comment has been minimized.

This comment has been minimized.

anamnavi left a comment

Choose a reason for hiding this comment

vboulineau commented Apr 12, 2021

TravisEz13 commented Apr 12, 2021

azure-pipelines bot commented Apr 12, 2021

TravisEz13 commented Apr 12, 2021

anamnavi left a comment • edited

Choose a reason for hiding this comment

PoshChan commented Apr 12, 2021

anamnavi commented Apr 12, 2021

donny-dont commented Apr 12, 2021

anamnavi commented Apr 12, 2021

TravisEz13 commented Apr 12, 2021 • edited by unfurl-links bot

ghost commented Jan 5, 2021 •

edited by ghost

anamnavi left a comment •

edited

TravisEz13 commented Apr 12, 2021 •

edited by unfurl-links bot