Update snapcraft.yaml files for arm binaries #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the failure of CI is from unrelated changes upstream in Snapcraft: see canonical/snapcraft#2883 As we're building our own Docker images then the changes will need to be massaged into our Dockerfiles to add |
|
CI fixed. (Sorry it took me so long to circle back and resync against main) |
|
cc: @TravisEz13 |
TravisEz13
requested changes
Sep 23, 2021
TravisEz13
requested changes
Sep 23, 2021
|
unfortunately I don't know about any available CI systems that have an ARM runner. I've been on the lookout for other snap projects, too.. |
Add arm32 and arm64 binaries if the build is executed on an appropriate host Signed-off-by: Daniel Llewellyn <daniel@bowlhat.net>
lucyllewy
force-pushed
the
arm-binaries
branch
from
480f4a6
to
53b75e8
Compare
added 3 commits
September 23, 2021 19:44
* Be explicit about supported platforms. Fail if the platform is unsupported. Signed-off-by: Dani Llewellyn <diddledani@ubuntu.com>
Use `rm -f` for `libcrypto.so.1.0.0` and `libssl.so.1.0.0` to cope with any cases where these aren't present. My local build fails here without this change Signed-off-by: Dani Llewellyn <diddledani@ubuntu.com>
TravisEz13
approved these changes
Sep 23, 2021
|
Thanks for the updates. |
|
I don't have a build environment for this, but I have been promised one "soon". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add arm32 and arm64 binaries of PowerShell if the build is executed on an appropriate host.
To build an arm32 or arm64 version of the snap it will be necessary to modify the build-bots to execute the job on arm32 and arm64 hosts in addition to the current amd64. I believe it will also require additional
Dockerfiledefinitions (at./tools/releaseBuild/Images) to create an appropriatesnapcraftcontainer for each new architecture.Fixes #55
Fixes #73
Signed-off-by: Daniel Llewellyn daniel@bowlhat.net