Add preview package #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unused packages equivalent of PowerShell/PowerShell@d663b41
TravisEz13
force-pushed
the
add_preview_package
branch
from
66f2868
to
84f69da
Compare
TylerLeonhardt
approved these changes
Jul 2, 2018
appveyor.yml
Outdated
| Purpose: stable | ||
|
|
||
| install: | ||
| # - ps: Install-module pester -Scope CurrentUser -Force -SkipPublisherCheck |
There was a problem hiding this comment.
nit: any reason for this commented out code?
preview/snap/snapcraft.yaml
Outdated
| version=$(curl -s 'https://raw.githubusercontent.com/PowerShell/PowerShell/master/tools/metadata.json' | jq .NextReleaseTag | sed 's/"//g' | sed 's/v//') | ||
| echo $version | ||
| fi | ||
| summary: PowerShell for every system |
There was a problem hiding this comment.
nit: GitHub has an exclamation mark at the end. Not sure if you want to add that.
tools/releaseBuild/build.json
Outdated
| "DockerImageName": "ps-snap-ubunutu-16-04", | ||
| "BinaryBucket": "release" | ||
| } | ||
| ] |
There was a problem hiding this comment.
nit: the indenting of this file is off.
| @@ -24,6 +32,8 @@ Push-Location | |||
| try { | |||
| Write-Verbose "snapcraft version $(snapcraft --version)" -Verbose | |||
| Set-Location $location | |||
| Set-location $directory | |||
There was a problem hiding this comment.
nit: maybe just do Set-Location "$location\$directory" or Set-Location "$location/$directory"?
|
LGTM! |
|
Any changes to the RFC will be addressed later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements PowerShell/PowerShell-RFC#134
@tylerl0706 Can your review?