Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HiddenAttribute to decorate classes #18914

Closed
SeeminglyScience opened this issue Jan 10, 2023 · 9 comments
Closed

Allow HiddenAttribute to decorate classes #18914

SeeminglyScience opened this issue Jan 10, 2023 · 9 comments
Labels
Issue-Enhancement the issue is more of a feature request than a bug Resolution-No Activity Issue has had no activity for 6 months or more Up-for-Grabs Up-for-grabs issues are not high priorities, and may be opportunities for external contributors WG-Interactive-IntelliSense tab completion

Comments

@SeeminglyScience
Copy link
Collaborator

Summary of the new feature / enhancement

And exclude decorated classes from type name completion

Proposed technical implementation details (optional)

No response

@SeeminglyScience SeeminglyScience added Issue-Enhancement the issue is more of a feature request than a bug Needs-Triage The issue is new and needs to be triaged by a work group. labels Jan 10, 2023
@SeeminglyScience
Copy link
Collaborator Author

The Engine WG discussed this (as part of the discussion for #13465) and agree that it would be useful

@SeeminglyScience SeeminglyScience added Up-for-Grabs Up-for-grabs issues are not high priorities, and may be opportunities for external contributors and removed Needs-Triage The issue is new and needs to be triaged by a work group. labels Jan 10, 2023
@iSazonov iSazonov added the WG-Interactive-IntelliSense tab completion label Jan 10, 2023
@iSazonov
Copy link
Collaborator

/cc @MartinGC94

@SeeminglyScience
Copy link
Collaborator Author

(wouldn't be mad at throwing in #18642 while we're at it)

@MartinGC94
Copy link
Contributor

The hidden keyword is used for class members. Wouldn't it feel more natural to extend its usage to class definitions as well? So the syntax would look like this: hidden class MyClass {}.
The same goes for the other request for functions where the keyword would allow you to leave out a param block in the function definition.

@SeeminglyScience
Copy link
Collaborator Author

For this particular issue the use case is primarily for classes written in C# so the keyword wouldn't necessarily be applicable.

For functions/variables/etc keep in mind we'd have to make hidden a keyword outside of classes. I don't think the benefit is worth the potential breaks (functions named hidden for example). But allowing HiddenAttribute to decorate classes doesn't exclude the possibility of adding a hidden keyword in the future, and the implementation would likely be simply decorating with the attribute anyway.

Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

1 similar comment
Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-No Activity Issue has had no activity for 6 months or more labels Nov 15, 2023
Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

Copy link
Contributor

This issue has been marked as "No Activity" as there has been no activity for 6 months. It has been closed for housekeeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement the issue is more of a feature request than a bug Resolution-No Activity Issue has had no activity for 6 months or more Up-for-Grabs Up-for-grabs issues are not high priorities, and may be opportunities for external contributors WG-Interactive-IntelliSense tab completion
Projects
None yet
Development

No branches or pull requests

3 participants