Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwsh.exe shim from .NET tool install is not signed #20557

Closed
5 tasks done
mthalman opened this issue Oct 23, 2023 · 3 comments · Fixed by #21559
Closed
5 tasks done

pwsh.exe shim from .NET tool install is not signed #20557

mthalman opened this issue Oct 23, 2023 · 3 comments · Fixed by #21559
Labels
In-PR Indicates that a PR is out for the issue

Comments

@mthalman
Copy link

Prerequisites

Steps to reproduce

dotnet tool install --global PowerShell

Expected behavior

`%USERPROFILE%\.dotnet\tools\pwsh.exe` should be a signed file

This is particularly needed for the .NET SDK container images which [install PowerShell as a global tool](https://github.com/dotnet/dotnet-docker/blob/6ba62d6825b9f45b3d665ab6cc930808a40d63c6/src/sdk/8.0/nanoserver-ltsc2022/amd64/Dockerfile#L39-L47).

Actual behavior

`%USERPROFILE%\.dotnet\tools\pwsh.exe` is unsigned

Error details

No response

Environment data

PowerShell 7.3.8

Visuals

No response

@mthalman mthalman added the Needs-Triage The issue is new and needs to be triaged by a work group. label Oct 23, 2023
@mthalman
Copy link
Author

There is documentation for how this shim can be predelivered rather than generated at install time. This would allow PowerShell to deliver a signed version of it.

https://github.com/dotnet/sdk/blob/main/documentation/general/signing-global-tool-packages.md

@SteveL-MSFT
Copy link
Member

cc @adityapatwardhan

Copy link
Contributor

microsoft-github-policy-service bot commented May 3, 2024

📣 Hey @mthalman, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Triage The issue is new and needs to be triaged by a work group. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Indicates that a PR is out for the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants