Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UTF8 Tests for Invoke-WebRequest and Invoke-RestMethod #4890

Closed
markekraus opened this issue Sep 21, 2017 · 5 comments
Closed

Improve UTF8 Tests for Invoke-WebRequest and Invoke-RestMethod #4890

markekraus opened this issue Sep 21, 2017 · 5 comments
Labels
Issue-Discussion the issue may not have a clear classification yet. The issue may generate an RFC or may be reclassif Resolution-No Activity Issue has had no activity for 6 months or more WG-Quality-Test issues in a test or in test infrastructure

Comments

@markekraus
Copy link
Contributor

The current tests (soon to be) added in #4869 are an improvement from before but, perhaps, some better tests could be added.

Possibilities include ensuring there are no UTF16 or UTF32 chars, generating UTF8 from the WebListener controller instead of using a view, etc.

Also after #4888, a check can be made on the response headers from Invoke-RestMethod.
@markekraus markekraus mentioned this issue Sep 21, 2017
Merged
@markekraus markekraus changed the title Improve UTF8 Tests for Invoke-WebRequest and Invoke-Restmethod Improve UTF8 Tests for Invoke-WebRequest and Invoke-RestMethod Sep 21, 2017
@iSazonov iSazonov added WG-Quality-Test issues in a test or in test infrastructure Issue-Discussion the issue may not have a clear classification yet. The issue may generate an RFC or may be reclassif labels Sep 22, 2017
@iSazonov
Copy link
Collaborator

We could look how our file encoding tests works.
Also I believe it make sense to use `u{...} in test file if we need a constant test string - it protect our tests if we change the file encoding.

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

1 similar comment
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution-No Activity Issue has had no activity for 6 months or more label Nov 16, 2023
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This issue has been marked as "No Activity" as there has been no activity for 6 months. It has been closed for housekeeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Discussion the issue may not have a clear classification yet. The issue may generate an RFC or may be reclassif Resolution-No Activity Issue has had no activity for 6 months or more WG-Quality-Test issues in a test or in test infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markekraus @iSazonov