New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is no completion list for .NET static methods #163
Comments
Hah, yep, @dfinke and I were talking about this recently. He's been looking into fixing it in VS Code. From his last report, it sounds like VS Code is not asking for IntelliSense after the colon for whatever reason and then when you manually invoke it, the results aren't being displayed. May need to file a bug on the VS Code team if we can't work around it. |
So for instance members we get this request: READ MESSAGE:
{
"jsonrpc": "2.0",
"id": 8,
"method": "textDocument/completion",
"params": {
"uri": "file:///c%3A/Users/Keith/.vscode/extensions/ms-vscode.PowerShell-0.4.1/examples/DebugTest.ps1",
"position": {
"line": 1,
"character": 3
}
}
} and give a response like this (elided) {
"jsonrpc": "2.0",
"id": "8",
"result": [
{
"label": "Date",
"kind": 1,
"detail": null,
"documentation": "datetime Date { get; }",
"sortText": null,
"filterText": null,
"insertText": "Date",
"textEdit": {
"range": {
"start": {
"line": 1,
"character": 3
},
"end": {
"line": 1,
"character": 3
}
},
"newText": "Date"
},
"data": null
},
... For static .NET members, I'm seeing a completion request from VSCode upon typing the second {
"jsonrpc": "2.0",
"id": 12,
"method": "textDocument/completion",
"params": {
"uri": "file:///c%3A/Users/Keith/.vscode/extensions/ms-vscode.PowerShell-0.4.1/examples/DebugTest.ps1",
"position": {
"line": 2,
"character": 12
}
}
} and we respond with (also elided): {
"jsonrpc": "2.0",
"id": "12",
"result": [
{
"label": "MaxValue",
"kind": 1,
"detail": null,
"documentation": "static datetime MaxValue {get;}",
"sortText": null,
"filterText": null,
"insertText": "MaxValue",
"textEdit": {
"range": {
"start": {
"line": 2,
"character": 12
},
"end": {
"line": 2,
"character": 12
}
},
"newText": "MaxValue"
},
"data": null
},
{
"label": "MinValue",
"kind": 1,
"detail": null,
"documentation": "static datetime MinValue {get;}",
"sortText": null,
"filterText": null,
"insertText": "MinValue",
"textEdit": {
"range": {
"start": {
"line": 2,
"character": 12
},
"end": {
"line": 2,
"character": 12
}
},
"newText": "MinValue"
},
"data": null
},
... It seems like the PowerShell extension is performing correctly. |
Yes, looks like vs code is not displaying a drop down with the suggestions. |
So who's going to submit this to the VSCode team? We have a simple repro. :-) |
It's best if comes from an insider ;-) Sent from Outlook Mobile On Thu, Feb 18, 2016 at 9:20 AM -0800, "Keith Hill" notifications@github.com wrote: So who's going to submit this to the VSCode team? We have a simple repro. :-) Reply to this email directly or view it on GitHub: |
Seems like I've been elected ;) I'll file an issue when I get in to the office |
While you're at it, submit another issue on debug data tips. I've observed that scope plays some part here. Global scope variables act flakey at first. They maybe show once but not thereafter as long as we're executing in global scope. As soon as I step into a function, the global variables pop debug data tips quite reliably. Unfortunately, I then get no data tips for the variables inside the function I'm executing in. And when there is not a data tip, it is because we never received a |
I'm putting this on the backlog for now as I'm pretty sure this isn't an extension bug. The corresponding issue in VSCode doesn't have a milestone associated with it yet. |
Sounds good! |
Just ran into this problem myself. 😦 |
Hmm, I believe this will be fixed when VS Code 1.1.0 and PSES 0.6.0 is out, right @rkeithhill? |
Well it works correctly with an alpha build of 1.1.0 from 4/28 against PSES 0.5.0. Curiously, it doesn't work with the latest insiders build against PSES 0.5.0. You get a completion list but the contents are not the static members. So I guess it depends on which best represents what we will get with the 1.1.0 release of VSCode. |
I'm guesing the current 1.1.0-insiders is what will end up getting shipped next week. Alpha is probably the dev branch for 1.2.0. Weird that it isn't working though, they fixed the bug for that version... |
Maybe it also required a change on the extension side? I was running against 0.5.0 and not 0.6.0. |
Ahhh, right, we actually had a fix on our site that comes in 0.6.0. |
This works for me in VS Code 1.1.0! 🎊 I'm going to close this now. |
And that's with the 0.5.0 extension installed? Interesting, didn't think it'd work there too. Good to know! |
Freshly installed on a new install of Windows 10 Insider Build 14332! Yes, 0.5. |
To repro try:
The text was updated successfully, but these errors were encountered: