Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct dependency to get OS/process info in CoreCLR #278

Closed
daviwil opened this issue Aug 24, 2016 · 3 comments
Closed

Add correct dependency to get OS/process info in CoreCLR #278

daviwil opened this issue Aug 24, 2016 · 3 comments
Labels
Area-Logging Issue-Bug A bug to squash.

Comments

@daviwil
Copy link
Contributor

daviwil commented Aug 24, 2016

To use the new System.Runtime.InteropServices.RuntimeInformation class to gather OS and process information for our initial logging in EditorServicesHost I'll need to pull in the expected dependency package since PowerShell doesn't seem to ship with it. This work won't be possible until we start the conversion over to the dotnet-cli tools.
@daviwil daviwil added the Issue-Bug A bug to squash. label Aug 24, 2016
@daviwil daviwil added this to the Backlog milestone Aug 24, 2016
daviwil added a commit that referenced this issue Aug 24, 2016
@daviwil
Remove OS/process info gathering in CoreCLR
acafb4c 
This change temporarily removes the OS and process information gathering
from the CoreCLR version of PowerShell Editor Services because they cause
assembly loading errors.  This should be resolved by the upcoming conversion
to the dotnet cli tools.

Future resolution tracked by #278.
@TylerLeonhardt
Copy link
Member

Interesting - this still a problem since we've switched to dotnot-cli tools?

@daviwil
Copy link
Contributor Author

daviwil commented Jan 13, 2018

This required some dependency that I didn't have access to at the time. This is the place in the code where it was necessary:

https://github.com/PowerShell/PowerShellEditorServices/blob/master/src/PowerShellEditorServices.Host/EditorServicesHost.cs#L130

I think it should be fixable now but it isn't a super high priority.

TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this issue Feb 26, 2019
@daviwil
Merge pull request PowerShell#278 from mklement0/patch-1
e83dc74 
Update troubleshooting.md
@rjmholt
Copy link
Collaborator

rjmholt commented May 24, 2019

This is done!

@rjmholt rjmholt closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Logging Issue-Bug A bug to squash.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daviwil @TylerLeonhardt @rjmholt