Additional changes to allow PSReadLine to work in CLM #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
reviewed
Jun 4, 2020
| @@ -729,7 +729,7 @@ private async Task WritePromptStringToHostAsync(CancellationToken cancellationTo | |||
| { | |||
| } | |||
|
|
|||
| PSCommand promptCommand = new PSCommand().AddScript("prompt"); | |||
| PSCommand promptCommand = new PSCommand().AddScript("prompt", useLocalScope: true); | |||
There was a problem hiding this comment.
If prompt is usually dot-sourced in normal PowerShell, it might be worth adding a comment here. If this actually converts us to use normal behaviour, then no comment needed I imagine
There was a problem hiding this comment.
How silly of me... prompt is a function... so I switched to using AddCommand :)
src/PowerShellEditorServices/Services/PowerShellContext/Session/PSReadLinePromptContext.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/PowerShellContext/Session/PSReadLinePromptContext.cs
Show resolved
Hide resolved
rjmholt
approved these changes
Jun 6, 2020
| $module = Get-Module -ListAvailable PSReadLine | | ||
| Where-Object { $_.Version -gt '2.0.0' -or ($_.Version -eq '2.0.0' -and -not $_.PrivateData.PSData.Prerelease) } | | ||
| Where-Object {{ $_.Version -ge '2.0.2' }} | |
There was a problem hiding this comment.
Might be worth taking the version here out into a constant
There was a problem hiding this comment.
I'll do that next time 😅 I really don't want to test on my SAW again lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pending a 2.0.2 release of PSRL that has a fix for CLM.
On Windows PowerShell, for some reason... when PSReadLine is not a trusted module,
gmo -listdoes not show it. As a workaround, we attempt to load PSRL from our module path.This ensures PSRL will be loaded when the PSRL feature is used.