Fix error when piping IFilePosition to ConvertTo-ScriptExtent
#1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While resisting the urge to burn the entire file to the ground. Boy did I have some wild style choices five years ago.
When passing a single Line/Column value, we now assume you want a zero length extent of a single point. This was already the case for buffer ranges. Also take a pass at style because it was an abomination and I apologize to the world for doing it.
Offset calculation was hitting the same new line repeatedly as it didn't set the new offset for one *after* the new line char. Also empty extents pass null as `FileContext` so added some null checks.
andyleejordan
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.