Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import PSDesiredStateConfiguration by name #2062

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

andyleejordan
Copy link
Member

Resolve PowerShell/vscode-powershell#3971.

Import PSDesiredStateConfiguration by name, not by hard-coded path, and clean-up some inconsistencies.

Instead of a hard-coded path which doesn't always work. Also apply
`ErrorAction -Ignore` fix to Plaster module.
@andyleejordan andyleejordan requested a review from a team as a code owner September 7, 2023 20:31
@andyleejordan andyleejordan changed the title Andyleejordan/ps commands Import PSDesiredStateConfiguration by name Sep 7, 2023
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit 9e19755 Sep 7, 2023
13 checks passed
@andyleejordan andyleejordan deleted the andyleejordan/psCommands branch September 7, 2023 21:52
@kborowinski
Copy link

kborowinski commented Sep 15, 2023

@andyleejordan @SeeminglyScience This causes the progress bar to show up on console and stay on after module import, when using interactive debug session on PowerShell 5.1:

Animation

Could it be disabled with $ProgressPreference = "SilentlyContinue"?

@andyleejordan
Copy link
Member Author

@kborowinski yes it can and seems to work well: #2068

@andyleejordan
Copy link
Member Author

@kborowinski I had to redo that with #2081 after further investigation. Glad I tested better before I released!

@kborowinski
Copy link

@andyleejordan Good find Andy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Engine Issue-Bug A bug to squash.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

DesiredStateConfiguration module not found
3 participants