Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GitHub Actions for all CI #2110

Merged
merged 11 commits into from Dec 12, 2023
Merged

Switch to GitHub Actions for all CI #2110

merged 11 commits into from Dec 12, 2023

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Dec 8, 2023 •
edited

Does it work? It works great!

@andyleejordan andyleejordan force-pushed the andyleejordan/github-ci branch 16 times, most recently from d9a4b0b to 2c4fa04 Compare December 8, 2023 18:33
@andyleejordan andyleejordan changed the title Try GitHub Actions for all CI Switch to GitHub Actions for all CI Dec 8, 2023
@andyleejordan andyleejordan marked this pull request as ready for review December 8, 2023 18:34
@andyleejordan andyleejordan requested review from a team as code owners December 8, 2023 18:34
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Dec 8, 2023
andyleejordan
andyleejordan commented Dec 8, 2023
View reviewed changes
src/PowerShellEditorServices/Services/Analysis/PssaCmdletAnalysisEngine.cs
// PSScriptAnalyzer module.
if (VersionUtils.IsWindows)
{
sessionState.ExecutionPolicy = ExecutionPolicy.Bypass;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dkattan I bet this was at least a source of those irregular failures. We consistently set this elsewhere for the extension on the CLI (so its inherited to the whole process) or for tests manually in the test host (which these tests weren't using) but in your hosted case I bet it wasn't getting set here either and so failing to load the module.

@andyleejordan andyleejordan mentioned this pull request Dec 12, 2023
Merged
@andyleejordan andyleejordan mentioned this pull request Dec 12, 2023
Merged
@andyleejordan andyleejordan force-pushed the andyleejordan/github-ci branch 4 times, most recently from f4d04e0 to 8cb16dc Compare December 12, 2023 04:07
SeeminglyScience
SeeminglyScience approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan added this pull request to the merge queue Dec 12, 2023
@andyleejordan andyleejordan removed this pull request from the merge queue due to a manual request Dec 12, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@andyleejordan andyleejordan force-pushed the andyleejordan/github-ci branch 4 times, most recently from ec1f417 to 6fb58ea Compare December 12, 2023 21:10
@andyleejordan
Copy link
Member Author

Naming things is hard.

@andyleejordan andyleejordan merged commit 1a2db98 into main Dec 12, 2023
9 checks passed
@andyleejordan andyleejordan deleted the andyleejordan/github-ci branch December 12, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
Flying Fox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyleejordan @SeeminglyScience