Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report column number in stack frame when debugger stops #405

Merged
merged 1 commit into from Mar 25, 2017

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented Mar 25, 2017

This change causes the column number of the debugger's currently stopped
position to be passed through with the top stack frame. This allows VS
Code's debugger UI to show an indicator that points to where the debugger
stopped when stepping through code.

Resolve PowerShell/vscode-powershell#616

@rkeithhill
Copy link
Collaborator

Still a bummer we have to resort reflection in places.

@daviwil
Copy link
Contributor Author

daviwil commented Mar 25, 2017

Yeah, apparently there's a DisplayScriptPosition property on InvocationInfo but it returns null :( Had to find this approach by looking at the ISE code.

This change causes the column number of the debugger's currently stopped
position to be passed through with the top stack frame.  This allows VS
Code's debugger UI to show an indicator that points to where the debugger
stopped when stepping through code.

Resolve PowerShell/vscode-powershell#616
@daviwil daviwil added this to the 0.11.1 milestone Mar 25, 2017
@daviwil daviwil merged commit c0270c8 into PowerShell:develop Mar 25, 2017
@daviwil daviwil deleted the debugger-column-number branch March 25, 2017 00:19
@daviwil daviwil modified the milestones: 0.11.1, 0.12.0 Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants