Add support for running xUnit tests in VS Test Explorer #642
Conversation
Fix issue with running xUnit tests over and over. Have a better way to detect when the session details file has been written. Fix issue with ServiceReturnsPowerShellVersionDetails test, where it only worked when you ran the tests using x86 arch. It now runs correctly using x64.
|
BTW I'm not totally sure the xunit.runner.visualstudio NuGet pkg won't interfere with running the tests on PS Core on other platforms. I figure the automatic builds will let me know. If so, I should be able to make their inclusion conditional on net452 or something like that. |
|
I still have one more xUnit test issue where it is processing my personal profile.ps1 file which modifies the prompt function. I need to figure out a fix for that. |
|
The tests, unfortunately, can only run on windows 😔 they reference powershell.exe. I wish we could get them to run on all platforms 😔 |
| Debug.WriteLine($"Session details at '{sessionPath}' not available: {ex.Message}"); | ||
| } | ||
|
|
||
| Thread.Sleep(500); |
There was a problem hiding this comment.
BTW I timed this while loop in the debugger using VS perf tips and the time to read the file varied between about 350 ms to 1.2 secs so I figured 500 ms was a reasonable sleep time to cut down on the number of retries.
| @@ -825,7 +825,9 @@ public class LanguageServerTests : ServerTestsBase, IAsyncLifetime | |||
| Assert.StartsWith("5.", versionDetails.Version); | |||
| Assert.StartsWith("5.", versionDetails.DisplayVersion); | |||
| Assert.Equal("Desktop", versionDetails.Edition); | |||
| Assert.Equal("x86", versionDetails.Architecture); | |||
|
|
|||
| string expectedArchitecture = (IntPtr.Size == 8) ? "x64" : "x86"; | |||
There was a problem hiding this comment.
This will eventually be a problem when we want to run the tests on Non-Windows because on macOS x64 is represented as x86_64
There was a problem hiding this comment.
but that can be dealt with later. I see we have an Assert.StartsWith just a few lines up that mentions version 5 so we'll have to deal with that too.
There was a problem hiding this comment.
The PowerShellVersionDetails.Architecture property is an enum with only these values: Unknown, x86, x64. So I think it is OK represent a 64-bit macOS Architecture as x64. Besides the version number, the only other place this info is used is to send back to the extension. And it does get logged. Even the log chooses to represent the Architecture.x64 val as simply 64-bit:
Version: Microsoft Windows NT 10.0.16299.0
Arch: 64-bit
In this regard, I like the IntPtr.Size test better than looking at env vars.
* Fix detection of valid PS ext for debugging. Was previously only allowing lower case ps1 and psm1. I'm assuming that on *nix file systems, that PowerShell allows all variations of ps1,PS1,pS1,Ps1 as valid script extensions. Fix PowerShell#641 * Fix issue with debugging unsaved file. * Use same term used in the command palette. * Shorten error message based on juneb feedback.
Fix issue with running xUnit tests over and over. Have a better
way to detect when the session details file has been written.
Fix issue with ServiceReturnsPowerShellVersionDetails test,
where it only worked when you ran the tests using x86 arch.
It now runs correctly using x64.