Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ignore] Prep for 2.0.0-preview.1 release #861

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Jan 23, 2019

This PR is mostly for documentation purposes. After this, I'll change the version back to just 2.0.0.

Note that this PR doesn't have the following changes:

  • appveyor.yml: might as well leave this at 2.0.0 if it's just for doc purposes
  • PowerShellEditorServices.psd1: PowerShell manifest files only support the version as 2.0.0, no SemVer suffix.

related PR: PowerShell/vscode-powershell#1716

@TylerLeonhardt TylerLeonhardt changed the title Prep for 2.0.0-preview.1 release [Ignore] Prep for 2.0.0-preview.1 release Jan 23, 2019
Copy link
Collaborator

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated

It also contains PSReadLine support in the integrated console for Windows behind a feature flag. PSReadLine provides a consistent and rich interactive experience, including syntax coloring and multi-line editing and history, in the PowerShell console, in Cloud Shell, and now in VSCode terminal. For more information on the benefits of PSReadLine, check out their [documentation](https://docs.microsoft.com/en-us/powershell/module/psreadline/about/about_psreadline?view=powershell-6).

To enable PSReadLine support in the Preview version on Windows, please add the following to your user settings:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit is quite VSCode specific. May be worth saying -FeatureFlags @('PSReadLine') instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch - added.

CHANGELOG.md Outdated

#### Breaking Changes

Due to the above changes, this version of the PowerShell Editor Services only works with PowerShell versions 5.1 and higher.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be explicit about 6.1+ support

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated 👍

@TylerLeonhardt TylerLeonhardt merged commit dafae03 into PowerShell:master Jan 23, 2019
@TylerLeonhardt TylerLeonhardt deleted the prep-for-2.0.0-preview.1-release branch January 23, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants